Fix confusing log message when checking present hypervisor #422
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ludfjig
changed the title
ludfjig
force-pushed
the
fix_log_message
branch
from
80eb8e3 to
2ba43fe
Compare
… specific hypervisors exist. This caused confusion if both kvm and mshv cargo features were enabled Signed-off-by: Ludvig Liljenberg <[email protected]>
ludfjig
force-pushed
the
fix_log_message
branch
from
2ba43fe to
315c997
Compare
…y needing to close fd Signed-off-by: Ludvig Liljenberg <[email protected]>
ludfjig
force-pushed
the
fix_log_message
branch
from
315c997 to
010b286
Compare
ludfjig
changed the title
danbugs
reviewed
Apr 17, 2025
danbugs
approved these changes
Apr 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When checking if a specific hypervisor is present using for example
kvm::is_hypervisor_present, and the hypervisor is not present, a log message is printed with the word 'Error' in it, which was confusing since it's not actually an error.The second commit does a slight cleanup by switching to Mshv::new() to avoid having to manually close the fd with raw libc calls.
Closes #379